Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical test failure occurring exclusively on Windows by adjusting the command line argument quoting within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the test_user_token test case failing on Windows by replacing single quotes with escaped double quotes in shell commands passed to the taos CLI.
Changes:
- Replace single-quoted SQL strings (
'show tokens;') with escaped double-quoted strings (\"show tokens;\") in two command constructions to ensure Windows compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request addresses a test failure on Windows by changing single quotes to double quotes in a shell command string. The fix is correct. I have provided suggestions to improve code readability by changing the outer quotes of the f-string to avoid using escaped characters, in line with PEP 8 recommendations.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes test_user_token test failure on Windows by swapping quote styles in shell commands. Windows cmd.exe does not recognize single-quoted strings, so the SQL argument passed via -s needed to use double quotes.
Changes:
- Changed two shell command strings in
test_user_token.pyto use double quotes around the SQL argument ("show tokens;") for Windows compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Description
fix failed test case on windows: test_user_token
Issue(s)
Checklist
Please check the items in the checklist if applicable.